search

rafaqz / DimensionalData.jl

Named dimensions and indexing for julia arrays and other data
https://rafaqz.github.io/DimensionalData.jl/stable/
MIT License
281 stars 41 forks source link

dont deepcopy on similar #446

Closed rafaqz closed 1 year ago

rafaqz commented 1 year ago

I had this for safety in case lookup vectors are written to, but that's a pretty rare thing in practice.

And deepcopy is an expensive operations to couple to every use of similar.

Edit: I guess this is a breaking change

Edit2: probably bumping compat is more disruptive than breaking the probably non-existant use cases that for some reason write to the dimension vectors manually. I very much doubt anyone is intentionally doing this.

codecov-commenter commented 1 year ago

Codecov Report

Merging #446 (18b389c) into main (2cf0097) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #446   +/-   ##
=======================================
  Coverage   89.59%   89.59%           
=======================================
  Files          39       39           
  Lines        2798     2798           
=======================================
  Hits         2507     2507           
  Misses        291      291
Impacted Files Coverage Δ
src/array/array.jl 96.59% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more