search

rafaqz / DimensionalData.jl

Named dimensions and indexing for julia arrays and other data
https://rafaqz.github.io/DimensionalData.jl/stable/
MIT License
271 stars 38 forks source link

Add vcat and hcat for AbstractDimArray #456

Closed sethaxen closed 1 year ago

sethaxen commented 1 year ago

hcat is only implemented for AbstractDimMatrix, because otherwise the 2nd column lacks the necessary dimension information.

Fixes #453

codecov-commenter commented 1 year ago

Codecov Report

Merging #456 (36d8092) into main (b253b60) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #456      +/-   ##
==========================================
+ Coverage   89.42%   89.46%   +0.04%     
==========================================
  Files          37       37              
  Lines        2590     2601      +11     
==========================================
+ Hits         2316     2327      +11     
  Misses        274      274
Impacted Files Coverage Δ
src/array/methods.jl 96.12% <100.00%> (+0.29%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sethaxen commented 1 year ago

I thought to also implement the reduce(vcat, xs) variants with the same implementation but could not get these to be type-stable, so that could be left for a future PR.