search

rafaqz / DimensionalData.jl

Named dimensions and indexing for julia arrays and other data
https://rafaqz.github.io/DimensionalData.jl/stable/
MIT License
271 stars 38 forks source link

Accelerate lookup of `At` for Unordered arrays #466

Open metab0t opened 1 year ago

metab0t commented 1 year ago

For Ordered Regular array of integer, we can get the index quickly from its start and span. (now we use searchsortedlast for all Ordered) For Unordered array of integer, can we use a Dict to accelerate the lookup?

rafaqz commented 1 year ago

Probably this is better: https://github.com/andyferris/AcceleratedArrays.jl

But there was some reason it didn't "just work" here, that may have changed now. Try a PR?

Edit: also no point doing this just for Integer - implement it for any unordered lookup.