Closed sethaxen closed 1 year ago
Merging #470 (ddcbaf5) into main (be957d9) will increase coverage by
0.06%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #470 +/- ##
==========================================
+ Coverage 89.64% 89.70% +0.06%
==========================================
Files 38 38
Lines 2636 2653 +17
==========================================
+ Hits 2363 2380 +17
Misses 273 273
Impacted Files | Coverage Δ | |
---|---|---|
src/array/array.jl | 96.45% <100.00%> (+0.48%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Thanks. Its unfortunate we have to do these "at least the first four args work" hacks, but better than nothing working.
This is a (particularly ugly) fix for #464 based on https://github.com/rafaqz/DimensionalData.jl/issues/464#issuecomment-1437256934 and https://github.com/rafaqz/DimensionalData.jl/issues/464#issuecomment-1437285282. It allows
DimUnitRange
to be mixed withInteger
and/orBase.OneTo
axes, so long as aDimUnitRange
appears within the first 4 axes, which should cover the most common cases. Fixes #464@mcabbot I ended up dispatching also on
Integer
types for axes because otherwise we need to also implement overloads to hitsimilar(::AbstractArray, ::Tuple)
for all of these combinations, which seemed unnecessary.~Still need to exhaustively test~, but now this works: