Closed kahaaga closed 1 year ago
Merging #527 (f5cab76) into main (6af9c1e) will decrease coverage by
0.15%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## main #527 +/- ##
==========================================
- Coverage 89.38% 89.24% -0.15%
==========================================
Files 39 39
Lines 2874 2882 +8
==========================================
+ Hits 2569 2572 +3
- Misses 305 310 +5
Files Changed | Coverage Δ | |
---|---|---|
src/array/show.jl | 90.74% <0.00%> (-4.41%) |
:arrow_down: |
... and 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Thanks
Actually best if you dont bump the version.
There is code we decided is breaking on master so we need to bump a major version, or revert (which I personally dont have time for)
Im waiting on the two other breaking PRs before bumping the minor version, to minimise downstream work.
Actually best if you dont bump the version. There is code we decided is breaking on master so we need to bump a major version, or revert (which I personally dont have time for) Im waiting on the two other breaking PRs before bumping the minor version, to minimise downstream work.
Ok, no problem! I reverted the version bump.
Fixes #525.
Changes:
Base.iterate(x::ShowWith
) andBase.iterate(x::ShowWith, i::Int)
, which were missing and caused the error in #525.Base.print(io::IO, x::ShowWith)
actually uses thecolor
andhidden
fields.Base.show(io::IO, x::ShowWith)
. This was necessary (although I don't understand exactly why) for pretty printing to work with custom arrays such asSVector
. Without it, things likeSVector
gets treated like a regular string and is printed in the default color (i.e. no dark text in the margins of the arrays).I also took the freedom to bump the patch version - hoping that a new version with the bug fix can be released in the near future 😁
EDIT:
I couldn't get the test suite to run locally, so I have no idea if this breaks anything (errors with something related to Aqua.jl). However, the following example demonstrates that the error in #525 is gone. Both 1D and higher-dimensional arrays are now shown correctly: