search

rafaqz / DimensionalData.jl

Named dimensions and indexing for julia arrays and other data
https://rafaqz.github.io/DimensionalData.jl/stable/
MIT License
271 stars 38 forks source link

Allow empty `DimStack` #529

Closed rafaqz closed 1 year ago

rafaqz commented 1 year ago

This required a few fixes to combinedims, uniquekeys and show to handle zero length things.

uniquekeys failure seems like a base julia bug, dispatch should not be able to recur in that method, but it does. Using map instead of broadcasts fixed it.

codecov-commenter commented 1 year ago

Codecov Report

Merging #529 (a8eb74a) into main (6af9c1e) will increase coverage by 0.23%. The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
+ Coverage   89.38%   89.62%   +0.23%     
==========================================
  Files          39       39              
  Lines        2874     2882       +8     
==========================================
+ Hits         2569     2583      +14     
+ Misses        305      299       -6
Files Changed Coverage Δ
src/stack/show.jl 97.50% <66.66%> (-2.50%) :arrow_down:
src/Dimensions/primitives.jl 93.96% <100.00%> (+0.07%) :arrow_up:
src/utils.jl 96.82% <100.00%> (+11.11%) :arrow_up:

... and 3 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more