Open bjarthur opened 1 year ago
Ok looks like we are missing methods for hvncat
.
Somehow I didn't even know that existed, looks like it was only added to Base in 2021.
Turns out this is kind of a nightmare to actually implement if we want the dimensions to be guaranteed to make sense afterwards. hvncat
accepts a pretty complex mosaic of n dimensional arrays as inputs and its really either we support everything here or stick with the fallback.
Basically calculating the new lookups and making sure they are correct for all arguments in all cases is very difficult.
We would need to:
DimArray
with the new dimensions we made.Getting that right and testing thoroughly will take someone a few days. @bjarthur, you're welcome to try, or anyone else who wants a challenge. Half of the code and checks are already written for cat
, but this is strictly harder because of the mosaic of different sized arrays that is allowed.
specifically,
cat
returns aDimArray
but;;
returns anArray
: