search

rafaqz / DimensionalData.jl

Named dimensions and indexing for julia arrays and other data
https://rafaqz.github.io/DimensionalData.jl/stable/
MIT License
271 stars 38 forks source link

fix parent of DimTable for DimStack #539

Closed rafaqz closed 11 months ago

rafaqz commented 11 months ago

@JoshuaBillson turns out I was mistaken about this, the parent object is really needed, our tests just didn't pick up on the difference because the stack only contains one array so the results are the same.

Now I just test the parent object is the exact stack passed in to be sure.

codecov-commenter commented 11 months ago

Codecov Report

Merging #539 (f1580c8) into main (36a2fcb) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #539   +/-   ##
=======================================
  Coverage   83.13%   83.13%           
=======================================
  Files          40       40           
  Lines        3297     3297           
=======================================
  Hits         2741     2741           
  Misses        556      556
Files Coverage Δ
src/tables.jl 96.52% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more