search

rafaqz / DimensionalData.jl

Named dimensions and indexing for julia arrays and other data
https://rafaqz.github.io/DimensionalData.jl/stable/
MIT License
271 stars 38 forks source link

Fix heatmap! #551

Closed felixcremer closed 10 months ago

felixcremer commented 11 months ago

This fixes the heatmap! function in Makie. This also adds tests for all bang functions for Makie.

I switched to using Makie because I hoped, that this would enable the testing of Makie on CI or is there something to gain by using GLMakie directly?

Closes #546 .

codecov-commenter commented 11 months ago

Codecov Report

Merging #551 (fceb57f) into main (77409f5) will increase coverage by 5.60%. Report is 2 commits behind head on main. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
+ Coverage   82.49%   88.09%   +5.60%     
==========================================
  Files          40       40              
  Lines        3324     3326       +2     
==========================================
+ Hits         2742     2930     +188     
+ Misses        582      396     -186
Files Coverage Δ
ext/DimensionalDataMakie.jl 89.47% <100.00%> (+89.47%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

rafaqz commented 11 months ago

Thanks!

Unfortunately adding Makie to CI is a huge overhead. Its not actuslly run during CI either.

Maybe its worthwhile?

felixcremer commented 11 months ago

I now use CairoMakie. That might be a good compromise, so that we don't have to deal wit GL on CI.

The broken tests are things that I would expect to work. The commented test also didnt work for the plain data.

felixcremer commented 11 months ago

The failure on nightly is that some of the @test_broken are going through and do not throw an error anymore.

rafaqz commented 11 months ago

Ok maybe comment them out, we can fix them later

felixcremer commented 11 months ago

I now fixed the volume! and volumeslices! functions and commented some tests for series which is basically #552 .

rafaqz commented 11 months ago

Amazing, thanks. Might be good to leave a TODO comment why those tests are commented.

felixcremer commented 10 months ago

I added TODOS to remind us to reenable the tests once the series works on the Makie side as expected. I also added a comment to #552.

This should be good to go now.

tomchor commented 10 months ago

Tests are passing :tada:

Merge and release a patch version?