search

rafaqz / DimensionalData.jl

Named dimensions and indexing for julia arrays and other data
https://rafaqz.github.io/DimensionalData.jl/stable/
MIT License
269 stars 37 forks source link

fix Makie ambiguities on 0.20 #574

Closed rafaqz closed 8 months ago

rafaqz commented 8 months ago

We needed explicit dispatch for makie recipes, the current solution hits ambiguity issues from the Union

CellGrid is actually aliased as DiscreteSurface which we already have, so we can ignore it.

codecov-commenter commented 8 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (f25fb78) 88.10% compared to head (9b3420d) 87.90%.

Files Patch % Lines
ext/DimensionalDataMakie.jl 33.33% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #574 +/- ## ========================================== - Coverage 88.10% 87.90% -0.21% ========================================== Files 40 40 Lines 3397 3405 +8 ========================================== Hits 2993 2993 - Misses 404 412 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.