search

rafaqz / DimensionalData.jl

Named dimensions and indexing for julia arrays and other data
https://rafaqz.github.io/DimensionalData.jl/stable/
MIT License
269 stars 37 forks source link

add Interpolations.jl extension #586

Open rafaqz opened 7 months ago

rafaqz commented 7 months ago

This is an idea for adding an Interpolations.jl extension.

It turns out there isn't a clean way to extend Interpolations.jl methods like interpolate or scale because really on a DimArray you would always want both and have the information for both already in one object.

So the idea here (and what i personally need the most) is to define an interpolation method that lets you interpolate from one AbstractDimArray to another in a single command.

We have most of the information we need to choose the interpolation method - users can specify e.g. Cubic or Linear if they really want to. But BSpline/Gridded we know from Regular / Irregular etc.

We may also want to provide an interpolator object that can interpolate points.

I'll probably leave this here for a while until its clearer what the best strategy is, but comments are welcome.

rafaqz commented 6 months ago

Closes #420

@DanDeepPhase we can implement this pretty easily now. But if you have any comments on syntax or how this should work that would help. See the new tests added here for an example.

asinghvi17 commented 1 month ago

Any particular reason this was closed?

rafaqz commented 1 month ago

In favour of

https://github.com/rafaqz/DimensionalData.jl/pull/609

Which needs tests, and I forgot about. And I'm not really sure on the best syntax. Feedback appreciated.

asinghvi17 commented 1 month ago

Did #609 get merged here? I don't see the log

rafaqz commented 1 month ago

It got merged to the branch yes, but the PR seems dead there's no reopen button

Maybe that's just a phone app thing idk

asinghvi17 commented 1 month ago

I guess the PR had to be reopened for the log to refresh...