rafaqz / DimensionalData.jl

Named dimensions and indexing for julia arrays and other data
https://rafaqz.github.io/DimensionalData.jl/stable/
MIT License
274 stars 39 forks source link

Breaking: better dimensional indexing #615

Closed rafaqz closed 7 months ago

rafaqz commented 8 months ago

Major overhaul of indexing to remove bugs and better use all the tools we already have.

Breaking:

rafaqz commented 7 months ago

@sethaxen is this close to being ready.

I don't expect a full review as its huge and patchy. But you should be aware of this as it will effect your types.

The two biggest changes for AbstractDimStack are:

sethaxen commented 7 months ago

Cool! I don't have time to review, but I ran all of my test suites using this PR, and I didn't encounter any new issues.

rafaqz commented 7 months ago

Thanks! Great they all pass. Mostly the things that broke were awful or buggy anyway and probably not used.

codecov-commenter commented 7 months ago

Codecov Report

Attention: 104 lines in your changes are missing coverage. Please review.

Comparison is base (3316875) 85.60% compared to head (a85ebf6) 84.21%.

Files Patch % Lines
src/dimindices.jl 80.00% 24 Missing :warning:
src/stack/indexing.jl 65.62% 22 Missing :warning:
src/array/indexing.jl 80.00% 14 Missing :warning:
src/Dimensions/primitives.jl 78.33% 13 Missing :warning:
src/LookupArrays/selector.jl 61.29% 12 Missing :warning:
src/stack/methods.jl 53.84% 6 Missing :warning:
src/array/array.jl 87.87% 4 Missing :warning:
src/array/methods.jl 25.00% 3 Missing :warning:
src/stack/stack.jl 85.00% 3 Missing :warning:
src/groupby.jl 60.00% 2 Missing :warning:
... and 1 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #615 +/- ## ========================================== - Coverage 85.60% 84.21% -1.39% ========================================== Files 45 45 Lines 3862 4055 +193 ========================================== + Hits 3306 3415 +109 - Misses 556 640 +84 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.