search

rafaqz / DimensionalData.jl

Named dimensions and indexing for julia arrays and other data
https://rafaqz.github.io/DimensionalData.jl/stable/
MIT License
263 stars 38 forks source link

Finalise docs #649

Closed rafaqz closed 4 months ago

rafaqz commented 4 months ago

@lazarusA @felixcremer I think this is getting close to finished.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 47.61905% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 83.78%. Comparing base (7662dc9) to head (a36e67f).

Files Patch % Lines
src/utils.jl 13.33% 13 Missing :warning:
src/stack/stack.jl 52.94% 8 Missing :warning:
src/groupby.jl 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #649 +/- ## ========================================== - Coverage 84.16% 83.78% -0.39% ========================================== Files 45 45 Lines 4068 4100 +32 ========================================== + Hits 3424 3435 +11 - Misses 644 665 +21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lazarusA commented 4 months ago

I think you should merge this one https://github.com/rafaqz/DimensionalData.jl/pull/647 into your current workflow, in order to work with the latest release. A lot of changes happened in the last days. Old workflow is broken :( . And there is still one last bug that will be fixed by https://github.com/LuxDL/DocumenterVitepress.jl/pull/36, apologies for the mess, but this will be better in the long run.

Edit: It looks like it will be safe to accept incoming changes from https://github.com/rafaqz/DimensionalData.jl/pull/647, all but the ones related to the side bar.

rafaqz commented 4 months ago

Ok #647 is merged and this is rebased against main