search

rafaqz / DimensionalData.jl

Named dimensions and indexing for julia arrays and other data
https://rafaqz.github.io/DimensionalData.jl/stable/
MIT License
274 stars 39 forks source link

Breaking: document and tweak stack interface #651

Closed rafaqz closed 7 months ago

rafaqz commented 7 months ago

Notably this breaks the AbstrackDimStack methods:

These should never have worked how they do (NamedTuple-like). Now they just throw an error - we can do something better and more Array-like with them later.

@sethaxen a few more breaks, hopefully wont break anything that matters.

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 70.37037% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 84.00%. Comparing base (025752f) to head (db9aecd).

Files Patch % Lines
src/stack/stack.jl 66.66% 16 Missing :warning:
src/array/array.jl 28.57% 5 Missing :warning:
src/stack/indexing.jl 80.00% 2 Missing :warning:
src/Dimensions/primitives.jl 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #651 +/- ## ========================================== - Coverage 84.08% 84.00% -0.09% ========================================== Files 45 45 Lines 4085 4095 +10 ========================================== + Hits 3435 3440 +5 - Misses 650 655 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sethaxen commented 7 months ago

It seems I didn't rely on any of these, so these changes don't break any of my tests.

rafaqz commented 7 months ago

They didn't make much sense so you probably avoided them. Good to know