search

rafaqz / DimensionalData.jl

Named dimensions and indexing for julia arrays and other data
https://rafaqz.github.io/DimensionalData.jl/stable/
MIT License
262 stars 38 forks source link

LookupArrays => Lookups #655

Closed rafaqz closed 4 months ago

rafaqz commented 4 months ago

I've wanted to do this for ages: the two sub-modules are now Dimensions and Lookups, not Dimensions and LookupArrays.

Having to type the Array part is annoying, and we say "lookup" and the getter is lookup, so the module may as well be Lookups and the supertype Lookup.

Its not actually breaking, as there are still aliases for the old names.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 78.41410% with 49 lines in your changes are missing coverage. Please review.

Project coverage is 84.07%. Comparing base (f5468f2) to head (607995f).

Files Patch % Lines
src/Dimensions/coord.jl 0.00% 11 Missing :warning:
src/Lookups/lookup_arrays.jl 83.33% 11 Missing :warning:
src/Lookups/selector.jl 80.39% 10 Missing :warning:
src/Dimensions/utils.jl 0.00% 4 Missing :warning:
src/Lookups/predicates.jl 62.50% 3 Missing :warning:
src/Lookups/set.jl 76.92% 3 Missing :warning:
src/Dimensions/dimension.jl 90.00% 1 Missing :warning:
src/Dimensions/predicates.jl 80.00% 1 Missing :warning:
src/Dimensions/show.jl 50.00% 1 Missing :warning:
src/Lookups/indexing.jl 75.00% 1 Missing :warning:
... and 3 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #655 +/- ## ========================================== + Coverage 84.05% 84.07% +0.02% ========================================== Files 45 45 Lines 4088 4087 -1 ========================================== Hits 3436 3436 + Misses 652 651 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.