rm icon links - Githubissues

rafaqz / DimensionalData.jl

Named dimensions and indexing for julia arrays and other data

https://rafaqz.github.io/DimensionalData.jl/stable/

MIT License

262 stars 38 forks source link

rm icon links #688

Closed lazarusA closed 2 months ago

lazarusA commented 3 months ago

as less as possible content in landing page. Minimalist hero page.

Same component as in Tyler.jl, which is working.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.81%. Comparing base (511734d) to head (1221416).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #688 +/- ## ========================================== + Coverage 83.79% 83.81% +0.01% ========================================== Files 46 46 Lines 4227 4226 -1 ========================================== Hits 3542 3542 + Misses 685 684 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

asinghvi17 commented 3 months ago

It may not be the icon links - GeometryOps and SwarmMakie work fine without them, and so did DocumenterVitepress. My bet is that it's some other change.

That being said it can't hurt to check.

lazarusA commented 3 months ago

Yes, indeed is none of them. Now, all missing things are fixed, including the ico file. Also, I tested the following cached files:

they are not getting updated after each new released tag. They should, we need to find a way to clear these files from the cache and generated new ones, the correct ones. It should be an option for vite in the config file.... at the moment I don't know how. I will need to look into it.

rafaqz commented 2 months ago

Should we merge this?

lazarusA commented 2 months ago

is just small fixes. So, yes merging is ok.