Bump Makie compat + patch version

rafaqz / DimensionalData.jl

Named dimensions and indexing for julia arrays and other data

MIT License

262 stars 38 forks source link

Closed asinghvi17 closed 1 month ago

asinghvi17 commented 1 month ago

  Invalid attribute colormap for plot type MakieCore.Plot{Makie.series}.

is the current error. I'm not sure where that colormap attribute is coming from, though, since it's not anywhere in the test file...

rafaqz commented 1 month ago

Maybe theres a default value somewhere...

lazarusA commented 1 month ago

it looks like series, not longer has a colormap attribute, it should be now just color. Which we were using to extended the amount of colours if we had more than 7 lines. https://github.com/rafaqz/DimensionalData.jl/blob/7e6d97a166ff6e5e8de2ca7e39a17f1d565dbdf3/ext/DimensionalDataMakie.jl#L251

(it looks like now we should remove it, and let Makie.series do the work)