search

rafaqz / DimensionalData.jl

Named dimensions and indexing for julia arrays and other data
https://rafaqz.github.io/DimensionalData.jl/stable/
MIT License
262 stars 38 forks source link

fixes series and updates Makie compat to latest #712

Closed lazarusA closed 1 month ago

lazarusA commented 1 month ago

this should close https://github.com/rafaqz/DimensionalData.jl/pull/710, https://github.com/rafaqz/DimensionalData.jl/issues/552

rafaqz commented 1 month ago

Something has changed in rainclouds too I guess

lazarusA commented 1 month ago

volumeslices and series are special cases. They don't fit into the current workflow, since series takes an input a matrix (which usually is assigned to a surface-like call, but now it needs to be a point-like one) and volumeslices is actually a heatmap call and not a volume one. This hasn't been supported so far. Hence I think we should move with this and open two specific issues for these uses cases.

rafaqz commented 1 month ago

Is this good to go? (I'm just ignoring nightly errors for now)

lazarusA commented 1 month ago

Series mutation method is not supported. The rest should be fine.

rafaqz commented 1 month ago

Is there something that can be done to fix it? Or should I just merge