search

rafaqz / DimensionalData.jl

Named dimensions and indexing for julia arrays and other data
https://rafaqz.github.io/DimensionalData.jl/stable/
MIT License
262 stars 38 forks source link

Add 'Not` to list in selector.jl #726

Closed alex-s-gardner closed 3 weeks ago

alex-s-gardner commented 3 weeks ago

Not sure if Not should be considered a Selector or a Selector Modifier

Addresses #721

rafaqz commented 3 weeks ago

Problem is the others are all <:Selector and Not is not!

Can we instead make a note that .. and Not also exist and work like real Selectors?

alex-s-gardner commented 3 weeks ago

Problem is the others are all <:Selector and Not is not!

Can we instead make a note that .. and Not also exist and work like real Selectors?

So Not and .. are already listed as Selectors here: https://rafaqz.github.io/DimensionalData.jl/dev/selectors#Selectors

rafaqz commented 3 weeks ago

Yes...they are selectors in the sense of selecting things.

But what you are changing is the docstring the abstract supertype Selector.... and its not the supertype of Not or ...

We can either just close this, or add the note, but we cant list them as being actually related to Selector in the programming sense, because they are not.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.84%. Comparing base (37cd1eb) to head (969002e). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #726 +/- ## ========================================== - Coverage 83.86% 83.84% -0.02% ========================================== Files 46 47 +1 Lines 4257 4296 +39 ========================================== + Hits 3570 3602 +32 - Misses 687 694 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.