search

rafaqz / DimensionalData.jl

Named dimensions and indexing for julia arrays and other data
https://rafaqz.github.io/DimensionalData.jl/stable/
MIT License
262 stars 38 forks source link

Add CodeCov upload token to fix codecov #738

Closed felixcremer closed 2 weeks ago

felixcremer commented 2 weeks ago

Currently the test coverage info at codecov is outdated by two months. This is because we are not using the codecov upload token. Could you please add the codecov upload token to the repo as described here:

https://docs.codecov.com/docs/adding-the-codecov-token#github-actions

rafaqz commented 2 weeks ago

Ok added. This is going to be extremely painful to do for every single package

felixcremer commented 1 week ago

This is still not uploading correctly. My latest PR still had the upload problems but I have no idea, why this is still happening. But apperently Lazaros PR #746 manages to upload some data.

felixcremer commented 1 week ago

Ahh, I just read a bit about that on the Julia slack and the problem seems to be, that forks don't have access to the Secrets, so it can't upload the data with the token, when the PR comes from outside of your github repository. So it seems, as if we would have to live with not having the current CodeCov info up there.

rafaqz commented 1 week ago

Why did they do this 😭