search

rafaqz / Extents.jl

A shared Extent object for Julia spatial data, with DE-9IM spatial predicates
MIT License
4 stars 3 forks source link

fix stack overflow in union and intersection #15

Closed rafaqz closed 11 months ago

rafaqz commented 1 year ago

union(hasextent, nothingextent) was causing overflow. instesection the same.

Now union will return whichever is an extent, and intersection will just return nothing. Not 100% sure union should return anything when one object has no Extent.

codecov-commenter commented 1 year ago

Codecov Report

Merging #15 (3cd25be) into main (6f918f0) will increase coverage by 1.75%. Report is 1 commits behind head on main. The diff coverage is 94.73%.

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   82.55%   84.31%   +1.75%     
==========================================
  Files           1        1              
  Lines          86      102      +16     
==========================================
+ Hits           71       86      +15     
- Misses         15       16       +1
Files Changed Coverage Δ
src/Extents.jl 84.31% <94.73%> (+1.75%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more