search

rafaqz / Extents.jl

A shared Extent object for Julia spatial data, with DE-9IM spatial predicates
MIT License
4 stars 3 forks source link

fix indexing constprop #24

Closed rafaqz closed 2 weeks ago

rafaqz commented 5 months ago

@asinghvi17 you might want this too if your benchmarking Shapefile.jl

Also needs review ;)

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.14%. Comparing base (10db148) to head (b41a6c5). Report is 3 commits behind head on main.

Files Patch % Lines
src/Extents.jl 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #24 +/- ## ========================================== - Coverage 87.76% 87.14% -0.63% ========================================== Files 1 1 Lines 139 140 +1 ========================================== Hits 122 122 - Misses 17 18 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rafaqz commented 5 months ago

Its just copying NamedTuple:

julia> (; a=1, b=2)[:c]
ERROR: type NamedTuple has no field c
Stacktrace:
 [1] getindex(t::@NamedTuple{a::Int64, b::Int64}, i::Symbol)
   @ Base ./namedtuple.jl:171
 [2] top-level scope
   @ REPL[37]:1

What is KeyError even for :cry: