search

rafaqz / Interfaces.jl

Macros to define and implement interfaces, to ensure they are checked and correct.
MIT License
72 stars 4 forks source link

`Interfaces.test(MyInterface{:optional_cond})` only checks `optional_cond`? #21

Open gdalle opened 9 months ago

gdalle commented 9 months ago

I initially expected it to test all the mandatory conditions by default

rafaqz commented 9 months ago

I had the exact same thought when I read it the other day.

I guess it should always test them all? Maybe the thinking was to cut down test time, but it doesn't make sense to run the optional ones without the mandaory ones really

gdalle commented 6 months ago

When writing GraphsInterfaceChecker I definitely wanted this to test mandatory parts too

rafaqz commented 6 months ago

For sure! A PR will be merged :)