rafaqz / Interfaces.jl

Macros to define and implement interfaces, to ensure they are checked and correct.
MIT License
72 stars 4 forks source link

Register BaseInterfaces.jl? #48

Open MilesCranmer opened 4 days ago

MilesCranmer commented 4 days ago

I thought BaseInterfaces.ArrayInterface looked pretty useful and wanted to add it to my test suite for DynamicQuantities for testing QuantityArray. However it looks like it's unregistered at the moment. Is this something on the roadmap or is BaseInterfaces intended only as an example?

rafaqz commented 4 days ago

It's meant to be registered, I just haven't had time to finish it (PhD + too many other packages...). Im not sure when I will have time either, definitely not in the next 4 months.

But if you have time to polish it up a bit and double check it all makes sense I can make time to review.

MilesCranmer commented 4 days ago

No rush! For me https://github.com/rafaqz/Interfaces.jl/pull/47 is much more important/timely, having BaseFeatures would just be gravy on top.