Closed alex-s-gardner closed 5 months ago
On main? And why not Intervals??
Ok I'm getting similar timings. The last PR was just general performance fixes not the Regular case, seems that is still needed.
(also note round
is incorrect here as it rounds towards zero, floor
is what you want...)
I think really this is a DimensionalData.jl selector performance issue. We shouldn't have to think about Contains
being slow on Regular
here or write any custom code, it should just work and be as fast as just diving by step and calling floor
.
100% agree... I don't think Rasters should need a specialized extract function... all of that should be handled by DD
Ok I made a DD issue to track this and fix at the source.
Manually calculating indices or using Interpolations is 3-5x faster than using extract()
Using extract()
Using calculated index
Using Interpolations