La/new vite docs: ready to merge

rafaqz / Rasters.jl

Raster manipulation for the Julia language

MIT License

209 stars 36 forks source link

La/new vite docs: ready to merge #675

Closed lazarusA closed 3 months ago

lazarusA commented 4 months ago

Let's see if CI is working.

lazarusA commented 4 months ago

I don't know why the DD restriction. Locally, is running ok.

@asinghvi17. Also, some issues with rplot. The example is a julia block in makie plots section.

rafaqz commented 4 months ago

I think the DD problem might be from GitHub actions caching? I had this somewhere else too.

lazarusA commented 4 months ago

@felixcremer how did u fixed for yax? u were having the same issue...

asinghvi17 commented 4 months ago

If you have admin privileges on the repo, you can delete all caches in the "Actions" tab

rafaqz commented 4 months ago

Ok cache is deleted, see how this goes. Documenter hasn't been passing completely for while...

asinghvi17 commented 4 months ago

Looks like UC Davis's server is down again

lazarusA commented 4 months ago

good. That fixed the error. But we need to increase the timeout on Downloads. Locally also takes a while. Ideas?

felixcremer commented 4 months ago

I added a Pkg.Registry.update(); call in the github action. This should solve these problems also in the future. See JuliaDataCubes/YAXArrays.jl@7474202 (#390)

rafaqz commented 4 months ago

Ok those are just worldclim/ucdavis outage problems now.

(We should really purge WorldClim from everything it happens too much - or maybe we can cache it?)

felixcremer commented 4 months ago

The problem with caching is, that this would be redistribution which is allowed only after permission https://worldclim.org/about.html. When we are using WorldClim as examples, we should find other example datasets that are more reliable or which we could host ourselves.

lazarusA commented 4 months ago

@felixcremer @rafaqz any suggestions for a different dataset provider for those examples. So that I can fix this and finish the PR.

rafaqz commented 4 months ago

Not sure. WorldClim files are relatively small which helps download time

rafaqz commented 4 months ago

Chelsea is a direct replacement, we could use the lowest resolution?

lazarusA commented 3 months ago

@rafaqz that should do it. Let's see if data is not longer an issue.

rafaqz commented 3 months ago

Now there's a real error ;)

ERROR: LoadError: invalid '@docs' syntax: @docs data_sources

lazarusA commented 3 months ago

Ok. Now is a path issue/missing images. The doctest creates images, that are not being saved at the right place or rather before they are needed by Vitepress. Will look into this later.

asinghvi17 commented 3 months ago

│ ERROR: You must set ENV["RASTERDATASOURCES_PATH"] to a path in your system

lazarusA commented 3 months ago

it is, here: https://github.com/rafaqz/Rasters.jl/blob/484cb172e35ccace8bf9106ec0f2d21f381a097c/.github/workflows/Documenter.yml#L47 and

(twice!) here:

https://github.com/rafaqz/Rasters.jl/blob/484cb172e35ccace8bf9106ec0f2d21f381a097c/docs/make.jl#L15

lazarusA commented 3 months ago

the error is only for the doctests. Really confused now.

rafaqz commented 3 months ago

Does the folder exist tho? It won't make one for you

Might need to add a call to mkpath

lazarusA commented 3 months ago

we r good now: https://rafaqz.github.io/Rasters.jl/previews/PR675/