rafatosta / zapzap

WhatsApp desktop application written in Pyqt6 + PyQt6-WebEngine.
GNU General Public License v3.0
55 stars 2 forks source link

Start manually minimized (not Start ZapZap with the system) #140

Closed deivi98 closed 1 year ago

deivi98 commented 1 year ago

Hi there,

Just discovered this repo today. It is amazing, just what I needed. There is just one thing I am missing, and that is the capability to start minimized.

I have found this portion of code which seems to manage window's behaviour, however, either zapzap command is not passing arguments to python program or I am missing something. Also, I think adding regular command help (zapzap --help) would be useful.

https://github.com/rafatosta/zapzap/blob/4394fc4c3073b07191b7e2b2a8364cc62c6a5e21/zapzap/__main__.py#L65-L71

Thanks in advance, great work!

rafatosta commented 1 year ago

It's strange it's not working. As soon as possible I will analyze and make the correction. Thanks for the feedback and using my app 😊

rafatosta commented 1 year ago

The minimized start is working properly. Are you running via flatpak?

deivi98 commented 1 year ago

Nope, I installed the package via AUR repository, maybe it is a previous version?

Also, what command are you using to start minimized? I was trying zapzap --hideStart

rafatosta commented 1 year ago

Nope, I installed the package via AUR repository, maybe it is a previous version?

Also, what command are you using to start minimized? I was trying zapzap --hideStart

Do not use the AUR version, as it is not kept by me and presents several errors because it is not developed thinking to execute outside Flatpak.

Anyway, in the comments you have the "solution".

deivi98 commented 1 year ago

Thanks for letting me about flatpak. However, it is still not working for me.

After running flatpak run com.rtosta.zapzap --hideStart, window stills pop up.

rafatosta commented 1 year ago

Thanks for letting me about flatpak. However, it is still not working for me.

After running flatpak run com.rtosta.zapzap --hideStart, window stills pop up.

Iso here is working perfeitally.I recommend stirring qualquer configurações feitas previously na pasta autosart ou até tudo da paste do app em .var

deivi98 commented 1 year ago

After trying a couple of things, I have discovered it does work, but if only if option Start ZapZap with the system is enabled. I want to start ZapZap minimized, but not when the system starts. And other people might even want to start it with the system minimized but with a command instead of activating option in UI.

The issue is command flatpak run com.rtosta.zapzap --hideStart does not work if Start ZapZap with the system option is disabled. From my point of view, I don't see why one thing is related to the other.

To me, the solution to this is changing line 68 from an and to an or:

https://github.com/rafatosta/zapzap/blob/4394fc4c3073b07191b7e2b2a8364cc62c6a5e21/zapzap/__main__.py#L65-L71

rafatosta commented 1 year ago

There is no one because, I just did it that way. I did not see sense to start manually told.

deivi98 commented 1 year ago

Please merge :)