search

rafecolton / docker-builder

Docker builder builds Docker images from a friendly config file.
MIT License
80 stars 11 forks source link

/jobs/:id does not look like it includes stderror in the response #131

Closed matthewotto closed 9 years ago

matthewotto commented 9 years ago

Right now if there is a failure it doesn't always make it into the response. It looks like maybe stderror isn't getting included.

Example:

/jobs response:

{
account: "account-name",
bobfile: "Bobfile",
completed: "0001-01-01T00:00:00Z",
created: "2014-09-17T19:25:06.208089668Z",
error: {
Message: "stat /tmp/docker-build-worker693829152/account-name/9373b750-95d3-4a9d-5f5f-4e90757415f0/node_modules/public/vendor/_normalize.scss: no such file or directory",
Code: 1
},
id: "0374c4e9-2973-407d-4990-c4cdae947061",
log_route: "/jobs/0374c4e9-2973-407d-4990-c4cdae947061/tail?n=100",
ref: "08a34ee5066d4ac813569cfdf591c5bec3e266ea",
repo: "repo-name",
status: "errored"
},

/jobs/:id response:

INFO[2411194] starting clone process                        account=account-name api_token_present=true clone_cache_option=no ref=08a34ee5066d4ac813569cfdf591c5bec3e266ea repo=repo-name
DEBU[2411194] attempting to clone                          
INFO[2411197] cloning successful                            account=account-name api_token_present=true clone_cache_option=no ref=08a34ee5066d4ac813569cfdf591c5bec3e266ea repo=repo-name
DEBU[2411197] attempting to create a builder               
INFO[2411197] building from file                            file=Bobfile
rafecolton commented 9 years ago

Yep, definitely a bug. Will fix.

rafecolton commented 9 years ago

Fixed :smile: