search

rafecolton / docker-builder

Docker builder builds Docker images from a friendly config file.
MIT License
80 stars 11 forks source link

Mysterious intermittent test failures #18

Closed rafecolton closed 10 years ago

rafecolton commented 10 years ago

The tests that copy files from the repo dir to the workdir occasionally fail

Do we have a race condition?

Possible causes:

rafecolton commented 10 years ago

This seems to be causing other issues, and it seems to be related to the file copying

rafecolton commented 10 years ago

Have been trying to track this down for some time. Seems that order matters with the test failure - spec seed -seed=1398815842 seems to cause the failures. That can't be the only issue though, because the copy is failing in use, not just in testing

rafecolton commented 10 years ago

Believe this issue is fixed by https://github.com/modcloth/bob/commit/0fd16266317cf4d56df1b7fa7bc01e43591b2fe3 and https://github.com/modcloth/bob/commit/e1855f8e87b94cdcb8f41ba0d38a65f9fd9d1768, though I'm not enormously happy with the solution. Leaving this open for now.

rafecolton commented 10 years ago

Marking this as fixed, but we may need to reopen when we switch back from shelling out to native code for cp -R

rafecolton commented 10 years ago

Nope, still not fixed.

rafecolton commented 10 years ago

NOTE: The tests are passing - it turns out that issue was only related, but the underlying issue with file copying is still present. May be possible to reproduce by running builder a number of times in quick succession on a project that has a reasonably large number of files.