search

rafecolton / docker-builder

Docker builder builds Docker images from a friendly config file.
MIT License
80 stars 11 forks source link

post build hook for running black box tests #42

Open rafecolton opened 10 years ago

rafecolton commented 10 years ago

maybe with bats, since it's pretty universal

colegleason commented 10 years ago

@rafecolton Could this post build hook also be used for running arbitrary scripts after a successful job (build/tag/push)?

rafecolton commented 10 years ago

@colegleason that's the general idea; however, there are some serious security implications of this feature, depending on the implementation. I'm also not 100% sure it's within the scope of this project.

I'd love to hear any thoughts you may have (on either the implementation or the scope).

colegleason commented 10 years ago

Yeah, after thinking about it for a bit I think I will just use docker-builder as a step in a larger CI build. To do that I will need an interface to check on the status of an async build or otherwise block until a build succeeds.

rafecolton commented 10 years ago

Yeah, running the job synchronously will be a simple thing to add (and already on the TODO list).

Checking the status of the build over HTTP will eventually be added as a feature as well, though that is slightly further down on the list

rafecolton commented 10 years ago

Maybe a good way to handle this without trying to shove too much functionality into docker-builder is to use outgoing webhooks like Travis/GitHub...

colegleason commented 10 years ago

I think that would be a good feature, but I also like the idea of blocking until a build completes as it makes it easier to add into scripts and workflows without adding an HTTP server into the mix to listen for the webhooks.

On Wed, Jul 2, 2014 at 4:14 PM, Rafe Colton notifications@github.com wrote:

Maybe a good way to handle this without trying to shove too much functionality into docker-builder is to use outgoing webhooks like Travis/GitHub...

— Reply to this email directly or view it on GitHub https://github.com/modcloth/docker-builder/issues/42#issuecomment-47849096 .

Cole Gleason

Student, University of Illinois at Urbana-Champaign Email: cg@colegleason.com Website: colegleason.com