search

rafecolton / docker-builder

Docker builder builds Docker images from a friendly config file.
MIT License
80 stars 11 forks source link

Make sync build wait for `docker push` #84

Closed colegleason closed 10 years ago

colegleason commented 10 years ago

It would be nice if this waited until after the push completed in case you want to block until you are able to pull the container for testing or deployment.

rafecolton commented 10 years ago

Agreed. Unfortunately, the implementation would be rather difficult.

Currently, push commands are handled by queued-command-runner. This is necessary to ensure that all of the push commands get run - they have to get run in sequence, because trying to run a push command for a repo while one is already running (even if the tags are different) results in an error. Unfortunately, using this library also adds complexity.

I've started some changes in the not-shelling-out-for-docker branch to use the go-dockerclient PushImage function instead of exec.Cmd for pushes. Not sure whether or not that would alleviate the need for queued-command-runner.

Do you have any thoughts on the implementation?

colegleason commented 10 years ago

@rafecolton I like the go-dockerclient route myself, just because it would give more control to Bob.

rafecolton commented 10 years ago

Related: https://github.com/modcloth/docker-builder/issues/83

rafecolton commented 10 years ago

Done!