Closed rafecolton closed 10 years ago
This pull request is now ready for review.
@jszwedko can you do code review? @colegleason can you verify that synchronous builds now wait for docker push
commands to finish?
Overall :+1: :+1:
@jszwedko feedback implemented, mind taking a look again?
Actually, don't merge just yet, there are a few issues with this
Ok, all good now
:+1: :shipit:
Merging for now, will deal with https://github.com/modcloth/docker-builder/pull/92#commitcomment-7136657 later.
TODO:
Bobfile
This pull request addresses the following issues:
os/exec
commands (ongoing)queued-command-runner
causing error messages to appear in the logsdocker push
tailfile
package instead ofos/exec
totail -n