Not shelling out for docker

rafecolton commented 10 years ago

TODO:

[x] allow users to specify docker registry creds per Bobfile
[x] do push commands still need to be queued like they did if we were shelling out?
- turns out they don't - hooray!
[x] update this comment indicating which github issues this addresses
[x] document the new stuff

This pull request addresses the following issues:

https://github.com/modcloth/docker-builder/issues/23 - removing some os/exec commands (ongoing)
https://github.com/modcloth/docker-builder/issues/83 - issue with queued-command-runner causing error messages to appear in the logs
https://github.com/modcloth/docker-builder/issues/84 - make sync build wait for docker push
https://github.com/modcloth/docker-builder/pull/88 - have job processing wait for asynchronous job to finish (related to #84 and #83)
https://github.com/modcloth/docker-builder/issues/91 - use docker's tailfile package instead of os/exec to tail -n
https://github.com/modcloth/docker-builder/issues/93 - server stops pushing after a while

rafecolton commented 10 years ago

This pull request is now ready for review.

@jszwedko can you do code review? @colegleason can you verify that synchronous builds now wait for docker push commands to finish?

jszwedko commented 10 years ago

Overall :+1: :+1:

rafecolton commented 10 years ago

@jszwedko feedback implemented, mind taking a look again?

rafecolton commented 10 years ago

Actually, don't merge just yet, there are a few issues with this

rafecolton commented 10 years ago

Ok, all good now

jszwedko commented 10 years ago

:+1: :shipit:

jszwedko commented 10 years ago

rafecolton / docker-builder