search

raffaello-camoriano / RBDemo

Reactive Behaviors Demo
1 stars 0 forks source link

icubsee improvements #28

Closed pattacini closed 10 years ago

pattacini commented 10 years ago

@skkkumar, consider the following comments/suggestions for your code:

  1. Always put copyright disclaimer in source files (cmake included).
  2. The updateModule() calls some blocking read; this means that the getPeriod should return 0.0, otherwise you loose 0.1 seconds for nothing.
  3. The ResourceFinder needs to get configured according to the new policy (i.e. without specifying "ICUB_ROOT").
skkkumar commented 10 years ago

Thanks. Added