search

rafgraph / spa-github-pages

Host single page apps with GitHub Pages
https://spa-github-pages.rafgraph.dev
MIT License
3.83k stars 565 forks source link

Some problem with service worker. #29

Closed wangjianio closed 5 years ago

wangjianio commented 5 years ago

When I use create-react-app build app and enable service worker, the first visit to subpath (like: *.github.io/example) would use github default 404 page but custom 404.html.

rafgraph commented 5 years ago

Not sure, but I don't think this is an issue with spa-github-pages.

rafgraph commented 5 years ago

If you have a failing example I might be able to help you out.