rafgraph / spa-github-pages

Host single page apps with GitHub Pages
https://spa-github-pages.rafgraph.dev
MIT License
3.83k stars 565 forks source link

No longer working for SEO purposes? #55

Closed jhildenbiddle closed 2 years ago

jhildenbiddle commented 2 years ago

It appears this approach no longer works for SEO purposes.

CleanShot 2022-01-02 at 09 21 40@2x
rafgraph commented 2 years ago

No it still works, the second link in your screenshot is for https://spa-github-pages.rafgraph.dev/?/sitemap-link-generator, so the pages in the sitemap are still discoverable to google. Google will omit pages from search results for other reasons (duplicate, not important etc), which is probably happening to the example and example two deep pages. I just tried it and for me it pulls up the example page as well.

Screen Shot 2022-01-02 at 10 30 35 AM
jhildenbiddle commented 2 years ago

Yep. True enough. Interestingly, when I revisit the same URL in google I now see the example page also. 🤷‍♂️

Thanks, @rafgraph.