search

rafguns / doidownloader

You give it DOIs, it gives you the article PDFs
MIT License
0 stars 0 forks source link

metadata_from_url returns silently on failure #16

Closed rafguns closed 1 year ago

rafguns commented 1 year ago

If no metadata can be found, metadata_from_url will return a 'succesful' LookupResult with a JSON-encoded empty list. Should we get an error instead?

rafguns commented 1 year ago

In other words, should we have an else: after these lines? https://github.com/rafguns/doidownloader/blob/50ebc76ac05fbf054a55e87567f15bc18e07eff1/doidownloader/doidownloader.py#L222-L225