search

rafoli / liferay-sample-workspace

2 stars 7 forks source link

LSW-51 Circuit Breaker Unit Test #58

Closed afablf closed 3 years ago

afablf commented 3 years ago

Import of dependencies, creation of circuit breaker test class and first test using REST Assured.

alexandresjunior commented 3 years ago

Looks good, but a few other comments: as this test is not replicating user flows through an interface, it's not a functional test, like LiferaySampleAngularTest and LiferaySampleTest test classes, but actually it is an API Integration test instead. I would recommend split liferay-sample-module-tests into two submodules, one for functional-tests and other for api-tests. A good reference for that is this repo. So, the commands for running those tests would be blade gw performTest and blade gw apiTest, respectively. Let me know if you have any questions about it.

alexandresjunior commented 3 years ago

looks good! @rafoli waiting for your final review and merge into main. the remaning formatting issues with respect to test module should be accomplished within LSW-52 branch.

rafoli commented 3 years ago

hey @afablf @alexandresjunior the functional tests are failing when executing:

./setup.sh init blade gw performTest

Is there any additional step I should take?

rafoli commented 3 years ago

hey @afablf , as you are refactoring this PR, I'll close this.