INLSW-58 Refactor functional test classes to the new test module

rafoli / liferay-sample-workspace

2 stars 7 forks source link

INLSW-58 Refactor functional test classes to the new test module #76

Closed afablf closed 2 years ago

afablf commented 3 years ago

https://services.liferay.com/browse/INLSW-58

alexandresjunior commented 3 years ago

@afablf looks good, but a few comments:

there are some conflicts to resolve first. try to rebase with main and/or delete and include those files again, if it's simpler.
headless mode is working fine, but it seems when we change the option to open browser, it's still running on headless mode. I'd suggest to put a condition inside setupAll method to check the browser property value.
also, there is a suggestion from formatSource task about that method's return object.
the sign in with sucess test case is failing. try to change the assert condition to a more general one, since those tests are still preliminary.

rafoli commented 3 years ago

hey @afablf , could you please the conflicts?

alexandresjunior commented 3 years ago

looks good for me now, tks!

afablf commented 3 years ago

Team,

To validate this PR, it's necessary to do the whole load state process, then run the commands blade gw apiTest to run the circuit breaker test and blade gw performTest to run the functional test.

For functional tests, the ~/liferay-sample-workspace/modules/liferay-test/functional-test-tdd/SeleniumProperties/SeleniumPropertyKeys.properties file can be edited to run headless or by opening the browser, it's currently set to open the browser.

sonarcloud[bot] commented 3 years ago

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication