search

rafritts / bunit

A unit testing framework for Shell scripts - namely Bash.
MIT License
196 stars 11 forks source link

Merging my fork? #22

Closed jasonheecs closed 7 years ago

jasonheecs commented 7 years ago

Hi @atz3ro,

Great library you made here! I have found it really useful. I have forked this project and done some rather extensive refactoring of the code to make it more maintainable (IMHO) and fix some bugs with the Line numbers reporting and error messages. Please refer to my fork. It is a rather extensive refactoring of the codebase, but would you be interested in a pull request?

rafritts commented 7 years ago

Hey, are you kidding me? I'm thrilled someone else even uses it, let alone enjoys it. If those unit tests all still pass then I would say I am definitely interested in a PR. I think your refactoring is fantastic. I didn't know enough about Bash to implement the call back stuff, but this is fantastic.

On Nov 21, 2016 10:58 AM, "Jason Hee" notifications@github.com wrote:

Hi @atz3ro https://github.com/atz3ro,

Great library you made here! I have found it really useful. I have forked this project and done some rather extensive refactoring of the code to make it more maintainable (IMHO) and fix some bugs with the Line numbers reporting and error messages. Please refer to my fork. https://github.com/jasonheecs/BashScriptTestingLibrary It is a rather extensive refactoring of the codebase, but would you be interested in a pull request?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/atz3ro/BashScriptTestingLibrary/issues/22, or mute the thread https://github.com/notifications/unsubscribe-auth/ARA4z9WDcN_w_MwOA-9t0fh8cMInfJ1sks5rAc3LgaJpZM4K4cY3 .

rafritts commented 7 years ago

@jasonheecs I took a deeper look at your changes, and I think they are great. Whenever you're ready, make the PR and ill merge it.