raft-tech / TANF-app

Repo for development of a new TANF Data Reporting System
Other
16 stars 3 forks source link

[A11y Bug] File picker causes reads of hidden content #1107

Open reitermb opened 3 years ago

reitermb commented 3 years ago

Description: The file picker component on the Data Files page reads "no file selected" even when there is a file selected. This is likely a result of the "no file selected" text not getting passed an aria-hidden=true property when it is visibly hidden.

Acceptance Criteria: Create a list of functional outcomes that must be achieved to complete this issue

Tasks: Create a list of granular, specific work items that must be completed to deliver the desired outcomes of this issue

Supporting Documentation: Please include any relevant log snippets/files/screen shots

https://user-images.githubusercontent.com/28515874/156947536-468b497d-4e92-4226-9f23-e8491326e92b.mov

valcollignon commented 2 years ago

@reitermb to review this ticket and circle back. per backlog refinement 12.21.21.

valcollignon commented 2 years ago

@reitermb to review this ticket and circle back. per backlog refinement 12.21.21.

@reitermb have you had a chance to review this? :)

valcollignon commented 2 years ago

Reviewed briefly in backlog 2.22.22. @reitermb will review.

andrew-jameson commented 2 years ago

Discussed in backlog refinement 3.1.22 -- @reitermb to still review. He will test to see if applicable.

reitermb commented 2 years ago

Currently getting a 400 error when I try to submit files so I'm blocked on re-testing the success message element of this, but I have confirmed that the no file selected bug still exists, as well as the download button disappearing when clicked.

Added a video and a little refinement to the ticket

stevenino commented 2 years ago

@reitermb to split out #1107 into required a11y fix and 2nd tix that can be pushed out to v3.1