Space Fill Checks for T1's, T4's, M1, and M4 Records

[elipe17]

Summary of Changes

• Updated preparsing on T1, T4, M1, M4, Tribal T1, and Tribal T4 to support minimum length requirements to parse
• Updated the case aggregates rejected query to not count multiplicities per record
• Added test to cover the rejected count Pull request closes #2826

How to Test

cd tdrs-frontend && docker-compose up
cd tdrs-backend && docker-compose up --build

1. Open http://localhost:3000/ and sign in.
2. Submit a datafile with any of the above mentioned records that do and don't meet length requirements
3. Verify you do or don't see the appropriate error messages.
4. Submit aggregates_rejected.txt and verify you see 3 pre-check parser errors, but only 1 rejected record. Beforehand, you would have seen the count of rejected records as 3.

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

• [x] error counts not duplicated for rejected
• [x] TANF T1 records are parsed if 117<= length <= 156
• [x] Tribal TANF and TANF T4 records are parsed if 36 <= length <= 71
• [x] Tribal TANF T1 records are parsed if 117<= length <= 122
• [x] SSP M1 records are parsed if 113 <= length <= 150
• [x] SSP M4 records are parsed if 36 <= length <= 66

Deliverable 2: Tested Code

• Are all areas of code introduced in this PR meaningfully tested?
  • [x] If this PR introduces backend code changes, are they meaningfully tested?
  • [x] If this PR introduces frontend code changes, are they meaningfully tested?
• Are code coverage minimums met?
  • [x] Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
  • [x] Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

• [x] Are backend code style checks passing on CircleCI?
• [x] Are frontend code style checks passing on CircleCI?
• [x] Are code maintainability principles being followed?

Deliverable 4: Accessible

• [ ] Does this PR complete the epic?
• [ ] Are links included to any other gov-approved PRs associated with epic?
• [ ] Does PR include documentation for Raft's a11y review?
• [ ] Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

• [x] Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

• [x] Does this PR provide background for why coding decisions were made?
• [ ] If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
• [ ] If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
• [ ] If this PR introduces dependencies, are their licenses documented?
• [x] Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

• [x] Does the OWASP Scan pass on CircleCI?
• [ ] Do manual code review and manual testing detect any new security issues?
• [ ] If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

• [ ] the purpose of the research
• [ ] methods used to conduct the research
• [ ] who participated in the research
• [ ] what was tested and how
• [ ] impact of research on TDP
• [ ] (if applicable) final design mockups produced for TDP development

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.11%. Comparing base (5e98971) to head (8d5def9). Report is 2 commits behind head on develop.

Additional details and impacted files

[](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2912?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) ```diff @@ Coverage Diff @@ ## develop #2912 +/- ## ======================================== Coverage 93.10% 93.11% ======================================== Files 272 272 Lines 7049 7055 +6 Branches 590 591 +1 ======================================== + Hits 6563 6569 +6 Misses 392 392 Partials 94 94 ``` | [Flag](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2912/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [dev-backend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2912/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `93.19% <100.00%> (+<0.01%)` | :arrow_up: | | [dev-frontend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2912/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `92.62% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2912?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [tdrs-backend/tdpservice/parsers/aggregates.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2912?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Faggregates.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9hZ2dyZWdhdGVzLnB5) | `97.91% <100.00%> (ø)` | | | [...s-backend/tdpservice/parsers/schema\_defs/ssp/m1.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2912?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Fssp%2Fm1.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy9zc3AvbTEucHk=) | `100.00% <ø> (ø)` | | | [...s-backend/tdpservice/parsers/schema\_defs/ssp/m4.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2912?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Fssp%2Fm4.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy9zc3AvbTQucHk=) | `100.00% <ø> (ø)` | | | [...-backend/tdpservice/parsers/schema\_defs/tanf/t1.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2912?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Ftanf%2Ft1.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy90YW5mL3QxLnB5) | `100.00% <ø> (ø)` | | | [...-backend/tdpservice/parsers/schema\_defs/tanf/t4.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2912?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Ftanf%2Ft4.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy90YW5mL3Q0LnB5) | `100.00% <ø> (ø)` | | | [...d/tdpservice/parsers/schema\_defs/tribal\_tanf/t1.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2912?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Ftribal_tanf%2Ft1.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy90cmliYWxfdGFuZi90MS5weQ==) | `100.00% <ø> (ø)` | | | [...d/tdpservice/parsers/schema\_defs/tribal\_tanf/t4.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2912?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Ftribal_tanf%2Ft4.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy90cmliYWxfdGFuZi90NC5weQ==) | `100.00% <ø> (ø)` | | | [tdrs-backend/tdpservice/parsers/validators.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2912?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fvalidators.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy92YWxpZGF0b3JzLnB5) | `89.92% <100.00%> (+0.07%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2912?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2912?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Last update [0b10e3f...8d5def9](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2912?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech).