search

raft-tech / TANF-app

Repo for development of a new TANF Data Reporting System
Other
16 stars 3 forks source link

Final mile procedures and updates #2931

Open victoriaatraft opened 3 months ago

victoriaatraft commented 3 months ago

Summary of Changes

New PR to correct for some unwanted conflicts with develop Closes #2801

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.96%. Comparing base (c503e1d) to head (880f13b). Report is 6 commits behind head on develop.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2931/graphs/tree.svg?width=650&height=150&src=pr&token=BA04YXPAL9&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech)](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2931?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) ```diff @@ Coverage Diff @@ ## develop #2931 +/- ## =========================================== - Coverage 92.97% 92.96% -0.01% =========================================== Files 276 276 Lines 7316 7322 +6 Branches 646 647 +1 =========================================== + Hits 6802 6807 +5 - Misses 413 414 +1 Partials 101 101 ``` | [Flag](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2931/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [dev-backend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2931/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `93.02% <ø> (-0.01%)` | :arrow_down: | | [dev-frontend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2931/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `92.60% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2931?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [...s-backend/tdpservice/parsers/schema\_defs/ssp/m1.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2931?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Fssp%2Fm1.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy9zc3AvbTEucHk=) | `100.00% <ø> (ø)` | | | [...s-backend/tdpservice/parsers/schema\_defs/ssp/m2.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2931?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Fssp%2Fm2.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy9zc3AvbTIucHk=) | `100.00% <ø> (ø)` | | | [...s-backend/tdpservice/parsers/schema\_defs/ssp/m3.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2931?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Fssp%2Fm3.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy9zc3AvbTMucHk=) | `90.90% <ø> (ø)` | | | [...s-backend/tdpservice/parsers/schema\_defs/ssp/m4.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2931?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Fssp%2Fm4.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy9zc3AvbTQucHk=) | `100.00% <ø> (ø)` | | | [...s-backend/tdpservice/parsers/schema\_defs/ssp/m5.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2931?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Fssp%2Fm5.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy9zc3AvbTUucHk=) | `100.00% <ø> (ø)` | | | [...s-backend/tdpservice/parsers/schema\_defs/ssp/m6.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2931?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Fssp%2Fm6.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy9zc3AvbTYucHk=) | `100.00% <ø> (ø)` | | | [...s-backend/tdpservice/parsers/schema\_defs/ssp/m7.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2931?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Fssp%2Fm7.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy9zc3AvbTcucHk=) | `100.00% <ø> (ø)` | | | [...-backend/tdpservice/parsers/schema\_defs/tanf/t1.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2931?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Ftanf%2Ft1.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy90YW5mL3QxLnB5) | `100.00% <ø> (ø)` | | | [...-backend/tdpservice/parsers/schema\_defs/tanf/t2.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2931?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Ftanf%2Ft2.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy90YW5mL3QyLnB5) | `100.00% <ø> (ø)` | | | [...-backend/tdpservice/parsers/schema\_defs/tanf/t3.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2931?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Ftanf%2Ft3.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy90YW5mL3QzLnB5) | `90.90% <ø> (ø)` | | | ... and [11 more](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2931?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2931?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2931?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Last update [001873d...880f13b](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2931?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech).
ADPennington commented 2 months ago

adding blocked tag pending feedback on validator changes.

victoriaatraft commented 2 months ago

adding blocked tag pending feedback on validator changes.

okay. I 100% deleted them, so sorry about that. @elipe17 will graciously add them back in so it can be good to go.

ADPennington commented 2 months ago

@victoriaatraft a few of these friendly names are still quite verbose. lets discuss options for a path forward at next UX sync. cc: @lfrohlich

victoriaatraft commented 2 months ago

@elipe17 @victoriaatraft i left comments on a couple of line changes that can be prioritized for merging, perhaps on another branch. defer to dev on how best to go about that.

Thanks @ADPennington! checked in with @elipe17 and will be tackling this, this afternoon and wrap up by tomorrow morning

elipe17 commented 2 months ago

@elipe17 @victoriaatraft i left comments on a couple of line changes that can be prioritized for merging, perhaps on another branch. defer to dev on how best to go about that.

@ADPennington, @victoriaatraft I pulled the changes into another branch: merge-first-changes and made that branch this branch's base branch. I tagged everyone on the new PR.

victoriaatraft commented 1 month ago

@ADPennington @lfrohlich I know it says change requested, I tried to resolve that but those changes were addressed by Eric :)

ADPennington commented 1 month ago

@ADPennington @lfrohlich I know it says change requested, I tried to resolve that but those changes were addressed by Eric :)

thank you. just one quick question on this. Any suggestions on an efficient way to test this? For context, all of the friendly names have changed with this PR which currently only appear in the error reports. I usually confirm these sorts of changes by submitting a test file that would yield the relevant error messages that have changed. I'm not sure if we have some test files relevant to this PR to help make this a little easier. @victoriaatraft @reitermb @elipe17

elipe17 commented 1 month ago

@ADPennington @lfrohlich I know it says change requested, I tried to resolve that but those changes were addressed by Eric :)

thank you. just one quick question on this. Any suggestions on an efficient way to test this? For context, all of the friendly names have changed with this PR which currently only appear in the error reports. I usually confirm these sorts of changes by submitting a test file that would yield the relevant error messages that have changed. I'm not sure if we have some test files relevant to this PR to help make this a little easier. @victoriaatraft @reitermb @elipe17

@ADPennington there is not an easy way for us to do this at the moment. Best we can do is submit files that have lots of errors, e.g. ADS.E2J.FTP1.TS06, and do a manual verification. The only way we might be able to actually test this programmatically is if we built a file generator that allowed us to specify if we want to fuzz the values for the record types. Then we could generate files that have an error for every single field in each record type quite easily.

ADPennington commented 1 week ago

unit tests now failing on this @elipe17 @victoriaatraft

elipe17 commented 1 week ago

Details

Ah yes, these failures are result of the recent PRs being merged. @ADPennington, @victoriaatraft I will take a look shortly.

elipe17 commented 5 days ago

@victoriaatraft and @ADPennington I resolved the suggestions/changes that were in my purview. I left a few open for Victoria/@reitermb to address.

victoriaatraft commented 2 days ago

@elipe17 @ADPennington resolved open suggestion and made the last to Alex's open comment. We're removing "Race/Ethnicity" thank you