2749 ftanf validation checks

atrimpe commented 2 months ago

Summary of Changes

Added validation requirements and tests to verify each change Pull request closes #2749

How to Test

List the steps to test the PR These steps are generic, please adjust as necessary.

cd tdrs-frontend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d
cd tdrs-backend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d

Open http://localhost:3000/ and sign in.
Proceed with functional tests as described herein.
Test steps should be captured in the demo GIF(s) and/or screenshots below.

Demo GIF(s) and screenshots for testing procedure

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

[x] TANF section 1: leading spaces county fips addressed
[x] TANF section 1: 0 is out-of-range for item # 76_1 and # 76_2 (CITIZENSHIP_STATUS)
[x] TANF section 2: leading spaces county fips addressed
[x] Tribal TANF section 1: leading spaces county fips addressed
[x] Tribal TANF section 1: ADD_WORK_ACTIVITIES (item # 61) should also zero-fill.
[x] SSP Section 1: leading spaces county fips addressed
[x] SSP Section 1: 00 is out-of-range for item # 37 (EDUCATION_LEVEL)
[x] SSP Section 1: 0 is out-of-range for item # 38 (CITIZENSHIP_STATUS)
[X] SSP Section 1: 0 is out-of-range for item # 39 (COOPERATION_CHILD_SUPPORT)
[x] SSP Section 1 (T3): 00 is out-of-range for item # 68_1 and 68_2 (EDUCATION_LEVEL)
[x] SSP Section 1 (T3): 0 is out-of-range for item # 69_1 and 69_2 (CITIZENSHIP_STATUS)
[x] SSP Section 2: leading spaces county fips addressed
[x] SSP Section 2: 00 is out-of-range for item # 23 (EDUCATION_LEVEL)
[x] SSP Section 2: 0 is out-of-range for item # 24 (CITIZENSHIP_STATUS)
[x] lfrohlich and/or adpennington confirmed that ACs are met.

Deliverable 2: Tested Code

Are all areas of code introduced in this PR meaningfully tested?
- [x] If this PR introduces backend code changes, are they meaningfully tested?
- [ ] If this PR introduces frontend code changes, are they meaningfully tested?
Are code coverage minimums met?
- [x] Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
- [x] Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

[x] Are backend code style checks passing on CircleCI?
[x] Are frontend code style checks passing on CircleCI?
[x] Are code maintainability principles being followed?

Deliverable 4: Accessible

[ ] Does this PR complete the epic?
[ ] Are links included to any other gov-approved PRs associated with epic?
[ ] Does PR include documentation for Raft's a11y review?
[ ] Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

[x] Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

[x] Does this PR provide background for why coding decisions were made?
[ ] If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
[ ] If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
[ ] If this PR introduces dependencies, are their licenses documented?
[x] Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

[x] Does the OWASP Scan pass on CircleCI?
[ ] Do manual code review and manual testing detect any new security issues?
[ ] If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

[ ] the purpose of the research
[ ] methods used to conduct the research
[ ] who participated in the research
[ ] what was tested and how
[ ] impact of research on TDP
[ ] (if applicable) final design mockups produced for TDP development

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 97.91667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.11%. Comparing base (1c0e7ea) to head (01c4117). Report is 1 commits behind head on develop.

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2951/graphs/tree.svg?width=650&height=150&src=pr&token=BA04YXPAL9&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech)](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2951?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) ```diff @@ Coverage Diff @@ ## develop #2951 +/- ## ======================================== Coverage 93.11% 93.11% ======================================== Files 272 273 +1 Lines 7071 7087 +16 Branches 597 598 +1 ======================================== + Hits 6584 6599 +15 - Misses 394 395 +1 Partials 93 93 ``` | [Flag](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2951/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [dev-backend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2951/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `93.19% <97.91%> (+<0.01%)` | :arrow_up: | | [dev-frontend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2951/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `92.62% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2951?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [...s-backend/tdpservice/parsers/schema\_defs/ssp/m1.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2951?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Fssp%2Fm1.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy9zc3AvbTEucHk=) | `100.00% <100.00%> (ø)` | | | [...s-backend/tdpservice/parsers/schema\_defs/ssp/m2.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2951?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Fssp%2Fm2.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy9zc3AvbTIucHk=) | `100.00% <ø> (ø)` | | | [...s-backend/tdpservice/parsers/schema\_defs/ssp/m3.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2951?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Fssp%2Fm3.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy9zc3AvbTMucHk=) | `100.00% <ø> (ø)` | | | [...s-backend/tdpservice/parsers/schema\_defs/ssp/m4.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2951?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Fssp%2Fm4.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy9zc3AvbTQucHk=) | `100.00% <100.00%> (ø)` | | | [...s-backend/tdpservice/parsers/schema\_defs/ssp/m5.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2951?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Fssp%2Fm5.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy9zc3AvbTUucHk=) | `100.00% <ø> (ø)` | | | [...s-backend/tdpservice/parsers/schema\_defs/ssp/m6.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2951?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Fssp%2Fm6.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy9zc3AvbTYucHk=) | `100.00% <100.00%> (ø)` | | | [...s-backend/tdpservice/parsers/schema\_defs/ssp/m7.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2951?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Fssp%2Fm7.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy9zc3AvbTcucHk=) | `100.00% <100.00%> (ø)` | | | [...-backend/tdpservice/parsers/schema\_defs/tanf/t1.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2951?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Ftanf%2Ft1.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy90YW5mL3QxLnB5) | `100.00% <100.00%> (ø)` | | | [...-backend/tdpservice/parsers/schema\_defs/tanf/t3.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2951?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Ftanf%2Ft3.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy90YW5mL3QzLnB5) | `100.00% <ø> (ø)` | | | [...-backend/tdpservice/parsers/schema\_defs/tanf/t4.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2951?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fparsers%2Fschema_defs%2Ftanf%2Ft4.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvcGFyc2Vycy9zY2hlbWFfZGVmcy90YW5mL3Q0LnB5) | `100.00% <100.00%> (ø)` | | | ... and [9 more](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2951?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2951?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2951?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Last update [156d26b...01c4117](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2951?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech).

atrimpe commented 2 months ago

T1 COUNTY_FIPS_CODE is a typo (does not exist)

ADPennington commented 1 month ago

has this ticket been reassigned @robgendron ?

robgendron commented 1 month ago

has this ticket been reassigned @robgendron ?

Yes, it has been reassigned to @elipe17

ADPennington commented 1 month ago

@elipe17 can you check into the following AC:

Tribal TANF Section 1:ADD_WORK_ACTIVITIES (item # 61) should also zero-fill.

elipe17 commented 1 month ago

@elipe17 can you check into the following AC:

Tribal TANF Section 1:ADD_WORK_ACTIVITIES (item # 61) should also zero-fill.

@ADPennington updated schema to zero fill ADD_WORK_ACTIVITIES in tribal t2.

raft-tech / TANF-app