2509 - Data submission email

[jtimpe]

Summary of Changes

Pull request closes #2509. Updates the send_data_submitted_email to

• include more information in the template
• send once parsing completes, rather when file upload completes
• distinguish "processed with errors" and "processed without errors" in the subject and preview line

How to Test

1. Update SENDGRID_API_KEY in your .env to a valid api key (i can provide one if you reach out). ensure SENDGRID_SANDBOX_MODE_IN_DEBUG remains False.
2. Run

   cd tdrs-backend && docker-compose up
   cd tdrs-frontend && docker-compose up --build

3. Set your account type to "Data Analyst"
4. Upload a data file (both containing errors and containing no errors)
5. Inspect the emails you receive

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

• [x] Aligned with design spec ("Near Term Lower-lift" version):
  • [x] Data analysts receive email notification that their data is processed
  • [x] Email subject leads with whether or not their data file had errors
  • [x] Email table contains columns for section, submitted by, and error report (Error Report Available/No Errors being possible values)
  • [x] Email body contains copy on where to access the error report in TDP and where to go for more information in the knowledge center
• [x] Replaces existing notifications for data file submission
• [x] Testing Checklist has been run and all tests pass
• [x] lfrohlich and/or adpennington confirmed that ACs are met.

Deliverable 2: Tested Code

• Are all areas of code introduced in this PR meaningfully tested?
  • [x] If this PR introduces backend code changes, are they meaningfully tested?
  • [x] If this PR introduces frontend code changes, are they meaningfully tested?
• Are code coverage minimums met?
  • [x] Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
  • [x] Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

• [x] Are backend code style checks passing on CircleCI?
• [x] Are frontend code style checks passing on CircleCI?
• [x] Are code maintainability principles being followed?

Deliverable 4: Accessible

• [x] Does this PR complete the epic?
• [ ] Are links included to any other gov-approved PRs associated with epic?
• [ ] Does PR include documentation for Raft's a11y review?
• [ ] Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

• [x] Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

• [x] Does this PR provide background for why coding decisions were made?
• [ ] If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
• [ ] If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
• [ ] If this PR introduces dependencies, are their licenses documented?
• [x] Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

• [x] Does the OWASP Scan pass on CircleCI?
• [ ] Do manual code review and manual testing detect any new security issues?
• [ ] If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

• [ ] the purpose of the research
• [ ] methods used to conduct the research
• [ ] who participated in the research
• [ ] what was tested and how
• [ ] impact of research on TDP
• [ ] (if applicable) final design mockups produced for TDP development

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 92.39%. Comparing base (2c52e80) to head (5a163d9). Report is 7 commits behind head on develop.

Additional details and impacted files

[](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2959?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) ```diff @@ Coverage Diff @@ ## develop #2959 +/- ## =========================================== + Coverage 92.36% 92.39% +0.02% =========================================== Files 271 271 Lines 6447 6496 +49 Branches 556 562 +6 =========================================== + Hits 5955 6002 +47 - Misses 397 399 +2 Partials 95 95 ``` | [Flag](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2959/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [dev-backend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2959/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `92.35% <93.93%> (+0.03%)` | :arrow_up: | | [dev-frontend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2959/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `92.62% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2959?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [tdrs-backend/tdpservice/data\_files/views.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2959?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fdata_files%2Fviews.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvZGF0YV9maWxlcy92aWV3cy5weQ==) | `89.18% <ø> (-0.82%)` | :arrow_down: | | [tdrs-backend/tdpservice/email/helpers/data\_file.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2959?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Femail%2Fhelpers%2Fdata_file.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvZW1haWwvaGVscGVycy9kYXRhX2ZpbGUucHk=) | `100.00% <100.00%> (ø)` | | | [tdrs-backend/tdpservice/scheduling/parser\_task.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2959?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fscheduling%2Fparser_task.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2Uvc2NoZWR1bGluZy9wYXJzZXJfdGFzay5weQ==) | `52.00% <60.00%> (+2.00%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2959/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2959?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2959?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Last update [613ee93...5a163d9](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2959?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech).

[ADPennington]

Emails are coming through and looking good 🚀

@reitermb could you remind me -- is there an adjacent UX ticket that updates the e-mail notifications page related to this change? I'm also curious if we have prepared language about when these will and wont get delivered? (e.g. not delivered if files are still in pending status)