raft-tech / TANF-app

Repo for development of a new TANF Data Reporting System
Other
16 stars 3 forks source link

2897 finalized reporting language #2962

Closed jtimpe closed 4 weeks ago

jtimpe commented 2 months ago

Summary of Changes

Pull request closes #2897 and closes #3024

How to Test

cd tdrs-backend && docker-compose up
cd tdrs-frontend && docker-compose up --build
  1. Open http://localhost:3000/ and sign in.
  2. Upload a datafile containing errors. Examine the submission history page/tables.
  3. Download the error report. Examine the header and columns.

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

Deliverable 2: Tested Code

Deliverable 3: Properly Styled Code

Deliverable 4: Accessible

Deliverable 5: Deployed

Deliverable 6: Documented

Deliverable 7: Secure

Deliverable 8: User Research

Research product(s) clearly articulate(s):

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.05%. Comparing base (fefbe14) to head (1fd7300). Report is 1 commits behind head on develop.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2962/graphs/tree.svg?width=650&height=150&src=pr&token=BA04YXPAL9&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech)](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2962?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) ```diff @@ Coverage Diff @@ ## develop #2962 +/- ## ======================================== Coverage 93.04% 93.05% ======================================== Files 276 276 Lines 7102 7108 +6 Branches 599 599 ======================================== + Hits 6608 6614 +6 Misses 399 399 Partials 95 95 ``` | [Flag](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2962/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [dev-backend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2962/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `93.11% <100.00%> (+<0.01%)` | :arrow_up: | | [dev-frontend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2962/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `92.62% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2962?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [tdrs-backend/tdpservice/data\_files/util.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2962?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fdata_files%2Futil.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2UvZGF0YV9maWxlcy91dGlsLnB5) | `90.00% <100.00%> (+1.76%)` | :arrow_up: | | [...mponents/SubmissionHistory/CaseAggregatesTable.jsx](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2962?src=pr&el=tree&filepath=tdrs-frontend%2Fsrc%2Fcomponents%2FSubmissionHistory%2FCaseAggregatesTable.jsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9TdWJtaXNzaW9uSGlzdG9yeS9DYXNlQWdncmVnYXRlc1RhYmxlLmpzeA==) | `81.25% <ø> (ø)` | | | [...components/SubmissionHistory/SubmissionHistory.jsx](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2962?src=pr&el=tree&filepath=tdrs-frontend%2Fsrc%2Fcomponents%2FSubmissionHistory%2FSubmissionHistory.jsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9TdWJtaXNzaW9uSGlzdG9yeS9TdWJtaXNzaW9uSGlzdG9yeS5qc3g=) | `100.00% <100.00%> (ø)` | | | [...ponents/SubmissionHistory/TotalAggregatesTable.jsx](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2962?src=pr&el=tree&filepath=tdrs-frontend%2Fsrc%2Fcomponents%2FSubmissionHistory%2FTotalAggregatesTable.jsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1mcm9udGVuZC9zcmMvY29tcG9uZW50cy9TdWJtaXNzaW9uSGlzdG9yeS9Ub3RhbEFnZ3JlZ2F0ZXNUYWJsZS5qc3g=) | `66.66% <ø> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2962?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2962?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Last update [69fb0f7...1fd7300](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2962?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech).