codecov[bot]
commented
2 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.97%. Comparing base (
b5f8bd7) to head (07701c8).
Closed jtimpe closed 1 day ago
codecov[bot]
commented
2 months ago All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.97%. Comparing base (
b5f8bd7) to head (07701c8).
reitermb
commented
2 months ago I have one question, but it doesn't halt the PR. In the Errors audit, @reitermb has the friendly_name in parenthesis; e.g.
Item 26 (Number of Months Countable toward Federal Time Limit). I leave it up to him whether that should be updated in this PR. Otherwise, great work!
Yeah, all friendly names should be in parentheses next to the item #'s—I believe that's currently the case for lower categories, right?
I think with that this is good to go re: my review!
ADPennington
commented
1 month ago per sync with @jtimpe and @reitermb:
develop branch environment. also need to discuss plan with @andrew-jameson for how/when to release this PR given cat 3 error message implicationsADPennington
commented
1 month ago @jtimpe sorry just noticed merge conflicts on this
ADPennington
commented
1 month ago @jtimpe @reitermb @andrew-jameson i tested this PR based on the most common cat 1, cat2, and cat 3 errors in prod since sprint 98 was released to prod. Please note:
Further below are the error messages I tested for reference ⬇️. let me know how we should proceed, especially re: cat 2 error messages.
cat 1: pre-parsing errors
header
HEADER record length is 24 characters but must be 23. HEADER: record length is 24 characters but must be 23.HEADER update indicator: N does not match D. HEADER Item 10 (update indicator): N does not match D.
HEADER record length is 2 characters but must be 23. Your file does not begin with a HEADER record.HEADER: record length is 2 characters but must be 23. Your file does not begin with a HEADER record.inconsistent fiscal period :heavy_check_mark:
Submitted reporting year:2022, quarter:Q4 doesn't match file reporting year:2023, quarter:Q4.Submitted reporting year:2022, quarter:Q4 doesn't match file reporting year:2023, quarter:Q4.inconsistent program type :heavy_check_mark:
Data does not match the expected layout for SSP Active Case Data. Data does not match the expected layout for SSP Active Case Data. record not correct length :heavy_check_mark:
T1 record length is 116 characters but must be 156. No records created.T1: record length of 116 characters is not in the range [117, 156]. No records created.cat 2 errors
T2: 14 is not in ['01', '02', '05', '07', '09', '15', '16', '17', '18', '99'].date of birth is required but a value was not provided.social security number is required but a value was not provided.T2 Item 49 (work participation status): 14 is not in [01, 02, 05, 07, 09, 15, 16, 17, 18, 99]. date of birth is required but a value was not provided. :warning: social security number is required but a value was not provided. :warning:45 :question: cat 3 errors
if family affiliation :1 validator1 passed then work participation status T2: 14 is not in ['01', '02', '05', '07', '09', '15', '17', '18', '19', '99']. if family affiliation :1 validator1 passed then social security number T2: 000000000 is in ['000000000', '111111111', '222222222', '333333333', '444444444', '555555555', '666666666', '777777777', '888888888', '999999999'].if family affiliation :1 validator1 passed then work participation status T2 Item -1 (work participation status): 14 is not in [01, 02, 05, 07, 09, 15, 17, 18, 19, 99]. :warning: if family affiliation :1 validator1 passed then social security number T2 Item -1 (social security number): 000000000 is in ['000000000', '111111111', '222222222', '333333333', '444444444', '555555555', '666666666', '777777777', '888888888', '999999999']. :warning:
jtimpe
commented
1 month ago @ADPennington i've updated the is required validator message to use the schema/item/friendly string formatting. this change applies to every field where the required=True
Summary of Changes
Pull request closes #2693
{record_type} Item {item_num} {friendly_name}: {error_msg}format for all cat2 validatorsformat_error_contextfunction makes future changes consistentoptionsisNumbervalidateRaceerror message typo fix - I didn't see a difference between the message included in the AC and what's already in the repo. If i missed something, please let me knowHow to Test
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlichand/oradpenningtonconfirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Reportcomment in PR)CodeCov Reportcomment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjollyandttran-hubusing Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):