raft-tech / TANF-app

Repo for development of a new TANF Data Reporting System
Other
16 stars 3 forks source link

2950 updated search index #2964

Open raftmsohani opened 2 months ago

raftmsohani commented 2 months ago

Summary of Changes

Pull request closes #2950 _

Originally, the scope (see #2950) was to limit the STTs in the STT filter list as well as enabling the user to choose two or more STTs from the filter list, as currently only one STT can be picked for filtering the STT from the table. However, a pre-requisite for enabling multi select is to fix django-508 issues. Two tickets have been created (see #3008 , and #3002 ) to fix these issues and then create a fix ticket following #3002.

Consequently, this PR only limits the SST shown in the filter to SSTs than can submit that file.

How to Test

List the steps to test the PR These steps are generic, please adjust as necessary.

cd tdrs-frontend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d
cd tdrs-backend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d 
  1. Open http://localhost:3000/ and sign in.
  2. Submit one or more files.
  3. Login to /admin page and go to /admin/search_indexes/ and choose the STT you submitted the files from and confirm that only the STTs that can submit for that STT are shown in the filter list on the right side.

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

Deliverable 2: Tested Code

Deliverable 3: Properly Styled Code

Deliverable 4: Accessible

Deliverable 5: Deployed

Deliverable 6: Documented

Deliverable 7: Secure

Deliverable 8: User Research

Research product(s) clearly articulate(s):

raftmsohani commented 1 month ago

PR is blocked by this bug: https://github.com/raft-tech/TANF-app/issues/3002

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 86.79245% with 7 lines in your changes missing coverage. Please review.

Project coverage is 92.94%. Comparing base (b5f8bd7) to head (25ca708).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2964/graphs/tree.svg?width=650&height=150&src=pr&token=BA04YXPAL9&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech)](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2964?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) ```diff @@ Coverage Diff @@ ## develop #2964 +/- ## =========================================== - Coverage 92.97% 92.94% -0.04% =========================================== Files 276 277 +1 Lines 7316 7368 +52 Branches 646 649 +3 =========================================== + Hits 6802 6848 +46 - Misses 413 419 +6 Partials 101 101 ``` | [Flag](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2964/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [dev-backend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2964/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `92.99% <86.79%> (-0.04%)` | :arrow_down: | | [dev-frontend](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2964/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | `92.60% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2964?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) | Coverage Δ | | |---|---|---| | [...ations/0029\_tanf\_tribal\_ssp\_alter\_verbose\_names.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2964?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fsearch_indexes%2Fmigrations%2F0029_tanf_tribal_ssp_alter_verbose_names.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2Uvc2VhcmNoX2luZGV4ZXMvbWlncmF0aW9ucy8wMDI5X3RhbmZfdHJpYmFsX3NzcF9hbHRlcl92ZXJib3NlX25hbWVzLnB5) | `100.00% <100.00%> (ø)` | | | [...rs-backend/tdpservice/search\_indexes/models/ssp.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2964?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fsearch_indexes%2Fmodels%2Fssp.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2Uvc2VhcmNoX2luZGV4ZXMvbW9kZWxzL3NzcC5weQ==) | `100.00% <100.00%> (ø)` | | | [...s-backend/tdpservice/search\_indexes/models/tanf.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2964?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fsearch_indexes%2Fmodels%2Ftanf.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2Uvc2VhcmNoX2luZGV4ZXMvbW9kZWxzL3RhbmYucHk=) | `100.00% <100.00%> (ø)` | | | [...backend/tdpservice/search\_indexes/models/tribal.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2964?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fsearch_indexes%2Fmodels%2Ftribal.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2Uvc2VhcmNoX2luZGV4ZXMvbW9kZWxzL3RyaWJhbC5weQ==) | `100.00% <100.00%> (ø)` | | | [...backend/tdpservice/search\_indexes/admin/filters.py](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2964?src=pr&el=tree&filepath=tdrs-backend%2Ftdpservice%2Fsearch_indexes%2Fadmin%2Ffilters.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech#diff-dGRycy1iYWNrZW5kL3RkcHNlcnZpY2Uvc2VhcmNoX2luZGV4ZXMvYWRtaW4vZmlsdGVycy5weQ==) | `30.58% <0.00%> (-2.33%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2964?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2964?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Last update [b5f8bd7...25ca708](https://app.codecov.io/gh/raft-tech/TANF-app/pull/2964?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=raft-tech).