Closed raftmsohani closed 1 month ago
Attention: Patch coverage is 71.69811%
with 15 lines
in your changes are missing coverage. Please review.
Project coverage is 92.96%. Comparing base (
01c4117
) to head (983aeb0
). Report is 1 commits behind head on develop.
@raftmsohani I'm not too sure if I'm missing something, but here are my results:
note:
@raftmsohani I'm not too sure if I'm missing something, but here are my results:
note:
- tried this after logging in via login.gov and via ams
- also got the same results via swagger (below)
@ADPennington : The first time error above is because you have /
at the end. the second error looks like you have added the environment variable as a string. If you want to add the env var for TOKEN_EXPIRATION_HOURS
Summary of Changes
Pull request closes #2901_
Added an endpoint to get token (that expires after X period of time) to call API endpoints
How to Test
List the steps to test the PR These steps are generic, please adjust as necessary.
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
/v1/security/get-token
) only accessible toOFA System Admin
TOKEN_EXPIRATION_HOURS
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):