Closed reitermb closed 2 months ago
Stub ticket, related to #2930
A11y reviewed w/ @ttran-hub and @victoriaatraft on 6/26/2024
Thanks @reitermb @victoriaatraft! As discussed: to help with managing the outstanding pending file, if possible, include the dynamic links to the pending source data files in the Django or STT submission history. The a11y review for the pending email layout template lgtm 🚀.
Awaiting content feedback and may need some dev input, 1 point remaining.
Capturing notes from UX sync:
cc @victoriaatraft
@reitermb changes made and ready for your review :)
Finishing review, will be in QASP sooon.
@ADPennington two versions are ready for review, especially content. There was a suggestion to remove STT from the subject line in the template due to cases where the STT names are very long. The version with the CTA button may still require you to login instead of viewing the files directly like the button implies. And one last idea, let me know if a bulleted format instead of a paragraph form would be easier to read, happy to adjust.
Notes for re-arrangement of subject line—check what replacement tags are called here & how they'll populate
@lfrohlich @ttran-hub @reitermb @victoriaatraft @robgendron is this ticket pending me? Sorry i may have lost track.
@ADPennington I am currently working my way through the email templates and updating the content reflect @reitermb screenshot today :)
Thanks for the final pass on this @victoriaatraft
@ADPennington should be good to go for your pass!
@victoriaatraft @reitermb just a couple of questions/comments:
file
vs file(s)
){Section} file for {Fiscal Year, Quarter} stuck in {file status} state
@ADPennington
@victoriaatraft @reitermb just a couple of questions/comments:
- will this email be delivered every time a file gets stuck? just wondering for the next bullet's language (i.e.
file
vsfile(s)
)
@reitermb correct me if i'm wrong (and any on the following below) but I believe it's every time a file gets stuck
- for the subject line can we construct it as follows for dev:
{Section} file for {Fiscal Year, Quarter} stuck in {file status} state
Yes
- will this email include a link to the datafiles page that's already filtered to "pending" files?
I believe there was a caveat to the template with the call to action button: view file in django admin console. in that you have to be already logged in to be taken to the admin console.
- have the design mockups passed a11y testing?
Yes
UX to add "file" to subject line as requested by Alex, update the screenshot here
cc @ADPennington
@ADPennington if the single word of "state" bothers you in the subject line, we can remove. Granted the subject line is responsive given the screen size. In design, we usually call single words on a line an widow or orphan. :)
@ADPennington if the single word of "state" bothers you in the subject line, we can remove. Granted the subject line is responsive given the screen size. In design, we usually call single words on a line an widow or orphan. :)
@victoriaatraft @reitermb we can keep "state" :). One minor suggestion, if it is possible to include the file id number in the body of this e-mail (especially in the event that there is no button), this would be great nice-to-have. This is qasp-approved from my perspective. ✅ cc: @ttran-hub @lfrohlich
@ADPennington thank you! We have an internal sync in a few I can check on if we can include the file ID number. I'll keep you posted and make updates accordingly. Thank you!
Update: We can include the file ID number. Andrew made note to do the lighter lift on the cadences of how often these emails will be sent (one email per file or list of files)
Description: Follows on from #831, delivers spec for sys admin notifications of files stuck in pending / other non-processing states
AC:
Tasks:
Deliverables: TDP Email Templates: #2985: Admin Notifiation for Stuck Data #2985: Admin Notifiation for Stuck Data with CTA
Notes: