Open elipe17 opened 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.99%. Comparing base (
b5f8bd7
) to head (599f628
).
3 points remaining.
Finishing creation of dashboards. Aiming to publish PR today - 2 point remaining.
Note, we can't deploy this again unless we update the elastic instance to 7.10.x manually. I did that once, but it seems other deployments reverted it back and the terraform refuses to update it in the pipeline.
Note, we can't deploy this again unless we update the elastic instance to 7.10.x manually. I did that once, but it seems other deployments reverted it back and the terraform refuses to update it in the pipeline.
@elipe17 You might have to add the version as a variable to terraform
Note, we can't deploy this again unless we update the elastic instance to 7.10.x manually. I did that once, but it seems other deployments reverted it back and the terraform refuses to update it in the pipeline.
@elipe17 You might have to add the version as a variable to terraform
@raftmsohani the terraform does specify the version, but it bombs out when it tries to update elastic in the pipeline. I could try deleting the elastic instance and see if it recreates it all together. But that would kill the qasp environment too for a little while.
Adding this reference to the PR for an annoying feature of Date based aggregations. I also added it in the comments of the scripted field I created for RPT_MONTH_YEAR.
Summary of Changes
Families
section in this document.Note: I did not create dashboards/visualizations for every single table in the linked document. If that is what we want, I can do so. Just didn't want to do too much.
How to Test
ADS.E2J.FTP1.TS06
and for Section 3, use the attached file below. Note, this file is a modified version of the original:ADS.E2J.FTP3.TS06
. ADS.E2J.FTP3.TS06.txtsource commands.sh
and then execute the new command:upload_kibana_objs
Visualizations
andDashboards
. Make sure your time range includes the datetime that you submitted your S1/S3 files or there will be no data to see.Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):